CCM-10553: Fix Dependabot Redoc #955
Conversation
|
This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: CCM-10553 |
There was a problem hiding this comment.
There a lot of change here but all-but-one appear to be minor or patch version updates that I'm not too concerned about. However, the one that worries me is ajv as that's 4 major version increments!
"ajv": "4.11.8 - 8",
"ajv": "^8.17.1",
I think it might be safer to back that one out of this PR and apply it separately under another ticket so that if it does cause issues we can roll it back without reverting all of the other updates
|
This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: CCM-10553 |
|
This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket: CCM-10553 |
simonlabarere
left a comment
simonlabarere
left a comment
There was a problem hiding this comment.
We need to investigate the sandbox unit test failures before merging this.
simonlabarere
dismissed
their stale review
Nevermind, this could not be reproduced locally and the sandbox pipeline passed the second time.
ScottFullerton-NHSE
deleted the
feature/CCM-10553-fix-dependabot-packages
branch
This reverts commit 95fb767.
3 participants
Summary
I've run pnpm update -r to update the files to see if this will fix the dependabot issue. However, it looks to have updated possibly more then we originally wanted. I've put this PR here to see what others think before attempting to merge it and see if it clears.
Reviews Required
Checklist